Requirements for code contributions

Formal requirements [1], [6], [3], [7]

• Patch format - tools (git, stgit, etc.)
• Logical separation
• Find maintainer
• Signed-off, Acked-by

Syntactic requirements [2], [4]

• Coding Style
• Avoid ifdefs [3]
• Compiler warnings

Functional requirements [3], [7]

• Does not break anything! (different configs)
• All unwindable (loadable modules)

Quality requirements [7]

• Reuse as much as possible (find common code, etc.)
• Be endianness-clean
• No magic constants
• Checker tools (sparse, etc.)
• Code must be maintainable by people other than authors

URLs:

1. http://www.denx.de/wiki/U-Boot/Patches
2. http://www.denx.de/wiki/U-Boot/CodingStyle
3. http://lwn.net/Articles/139918/
4. Linux CodingStyle
5. Linux SubmittingDrivers
6. Linux SubmittingPatches
7. Linux SubmitChecklist